Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary page breaks #395

Merged
merged 2 commits into from
Nov 1, 2024
Merged

remove unnecessary page breaks #395

merged 2 commits into from
Nov 1, 2024

Conversation

jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Nov 1, 2024

After adjusting the margins, it was noticed that many plots appeared on their own single page.
To combine more plots on a single page, we elected to remove several page breaks.

Supersedes #391

FYI @hodie and @MonikaFu

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.55%. Comparing base (0590812) to head (4739bad).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #395   +/-   ##
=====================================
  Coverage   9.55%   9.55%           
=====================================
  Files         27      27           
  Lines       2219    2219           
=====================================
  Hits         212     212           
  Misses      2007    2007           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdhoffa
Copy link
Member Author

jdhoffa commented Nov 1, 2024

Testing here: RMI-PACTA/workflow.transition.monitor#387

Copy link
Collaborator

@MonikaFu MonikaFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdhoffa jdhoffa merged commit 21f6919 into main Nov 1, 2024
9 checks passed
@jdhoffa jdhoffa deleted the remove_page_breaks branch November 1, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants